Limit number of runtime dependencies for fog. #325
Conversation
By default fog depends on all possible fog providers, which boosts unnecessary number of dependencies. fog-core on the other hand, have minimum amount of deps, and mimimum number of classes, which leaves developer more space by using only required provider. This commit reduces number of dependencies from 94 to 64.
|
I am unable to process this since I don't enough knowledge about the internal structure |
|
In general there are only two uses of I've also added the The only issue that I can see is the upgrade path, we should definitely mention in changelog that user is required to add In meantime I'll test it in personal project, and give feedback if there's anything to be still updated. |
|
btw also thing to note is that there is similar PR #300 but it includes |
|
👍 |
|
I've found another duplicate #295 with |
|
To reduce the no. of gem dependencies without breaking anything
|
|
sounds ok, but I would still leave it as option for user |
|
Either way I cannot judge what to do with this issue |
|
Does this intentionally not include |
|
Also FYI for anyone that wants to use this fork directly off of github - this fork is behind master several commits. I created my own fork of this fork that requires |
|
@PikachuEXE What is the state of this PR? Has @davidjrice ever expressed his opinion about this topic? There are multiple PRs about it and I didn't find anything from him. Some of these PRs are over a 1,5 years old, how long do you want to wait? Can we please find a solution for this? If @davidjrice doesn't want to decide it, someone else needs to make a decision. |
|
I agree. Note that I am busy with my job too :S |
|
Thanks 👍 No worries, no need to rush, I only think we shouldn't wait another 1,5 years :) |
|
Just released Need to change README + Upgrade note |
|
@SuperTux88 I will try to fix AWS integration text too before merging it |
|
I submitted a review to the PR, thanks for your work! 👍 |
|
|
|
This should be closed now I guess |
By default fog depends on all possible fog providers, which boosts unnecessary number of dependencies.
fog-coreon the other hand, have minimum amount of deps, and mimimum number of classes, which leaves developer more space by using only required provider.This commit reduces number of dependencies from 94 to 64.